Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues Natalia Kuleniuk Solar System #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Queues Natalia Kuleniuk Solar System #29

wants to merge 4 commits into from

Conversation

natalia-ku
Copy link

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? method is used to initialize an object of a class; it is executing when an instance of class Planet or Solar System is created
Describe an instance variable you used and what you used it for. @name - to store the name of planet, @@all_planets - to store all planets objects
Describe what the difference would be if your SolarSystem used an Array vs a Hash. If my planets and information about them is stored in hash, then planet's name would be key, and info about this planet will be values. The way to access the values will also changed.
Do you feel like you used consistent indentation throughout your code? yes, I tried my best to make sure my indentation is consistent

add some changes to not the repeat the same block of code twice
@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & a meaningful message. Well Done

Great work! Way to go way above and beyond the requirements AND optionals!

My only bit of picky advice I have is to leave any of the user interface stuff outside of the class instead of within a class method, like with calculate distance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants