Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laura Melgarejo/ Solar System #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lmelgarejos
Copy link

@lmelgarejos lmelgarejos commented Feb 15, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? To create a hash and an array where I am going to store data.

| Describe an instance variable you used and what you used it for. | I used "@name" as an instance variable to be able to use it outside of the method. However it was not necessary. I call the instance variables in another method in the same class. |

| Describe what the difference would be if your SolarSystem used an Array vs a Hash. |
I used an array in my PlanetarySystem which is filled with hashes. Right now I think the big difference would be the way I build my methods in that class, but I think I could use either of them. |

| Do you feel like you used consistent indentation throughout your code? | Yes, I do. |

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & a meaningful message. Well Done

Great work!

The added functionality looks great and suits your needs for creating the interactive portion. Good instincts in leaving the user interface code (lines 80-91) outside of the class.

In your method pretty_info, instead of calling puts for each line, could have all one string and use \n where you want a new line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants