Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Maria McGrew -Solar-System.rb #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Queues - Maria McGrew -Solar-System.rb #50

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? to name instance variables that can be used outside of the class
Describe an instance variable you used and what you used it for. an instance variable can be seen in any class, I used it to name the parts that describe the planets
Describe what the difference would be if your SolarSystem used an Array vs a Hash. an array would not have allowed me to call on the different parts of the planet's characteristics that were identified by the keys, it allowed those characteristics to change with each planet
Do you feel like you used consistent indentation throughout your code? yes

@ghost ghost changed the title Create Queues - Maria McGrew -Solar-System.rb Queues - Maria McGrew -Solar-System.rb Feb 23, 2017
@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & a meaningful message. Well Done

Overall, looks great!

One suggestion, the list_planet method would better suit being directly in the planet class instead, since it's only concerned about a single planet's information. That way you wouldn't have to pass a planet object as an argument. If it was part of the planet class, you could just use it's instance variables. And you would still be able to use it in the list_planets method, but like so instead (I changed the method name from list_planet to details):

@planets.each do |planet|
   planet.details
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant