Queues - Ting & Sofia - VideoStoreAPI

[Sofia15]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We looked at the relationship among movies/customers/rentals and decided to make an intermediate table for movies and customers through rentals.
List all the completed endpoints of your application.	/customers, /movies, /movies/:title, /rentals/:title/check-out, /rentals/:title/check-in, /rentals/overdue
Describe a set of positive and negative test cases you implemented for a model.	can create a customer with a name / without a name
Describe a set of positive and negative test cases you implemented for a controller.	Under movies_controller show methods, we test to get a movie and error message pop-up with no movie found.
How does your API respond when bad data is sent to it?	With providing error message
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We created overdue method in our model because it is more suitable to insert under model according to the site's business logic.
Do you have any recommendations on how we could improve this project for the next cohort?
Link to Trello	We didn't user trello, but we used ERD and project specifications as our guideline.
Link to ERD	https://www.lucidchart.com/invitations/accept/e093cb50-e0a9-4ade-9c1f-835de6f7f417

[droberts-sea]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Business Logic in Models	yes
All 3 required endpoints return expected JSON data	yes
Requests respond with appropriate HTTP Status Code	yes
Errors are reported	yes
Testing
Passes all Smoke Tests	yes
Model Tests - all relations, validations, and custom functions test positive & negative cases	yes
Controller Tests - URI parameters and data in the request body have positive & negative cases	some - tests for MoviesController and CustomersController look good, but RentalsController is missing tests entirely!
Optionals
POST routes use URI parameter and request body to add a new record to the database	no - this gave me an error
GET /customers shows how many movies are checked out by a customer	no
GET /movies/:title shows updated inventory	no
Overall

Good work overall! Looks like you put some good effort into the optionals, but I wasn't able to get them working. Still, I'm quite happy with what I see here.