DishBish by Olivia

[secretsharer]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	Having missed Monday, I did a lot of reading through the docs and had an opportunity to build much straight from those instead of just the lecture, to varying degrees of success. I spent much time in Postman. I found it helpful both in basic querying (I used q/r parameters) and in learning to use it as a shell/to figure our what wasn't returning correctly.
Describe your API Wrapper. How did you decide on the methods you created?	As I went along, its behavior of acting upon the controller and edamam's db at the same time became clearer - it's pulling and pushing what I need based on the simple lib/index method (my method), creating an instance of a recipe.
Describe an edge case or failure case test you wrote for your API Wrapper.	Okay - testing this was a bit opaque. I need more info. I felt like I was fumbling here quite a bit. (I think especially since I was making a concerted effort to dive deeper into Foundation as well on this project...though I doubt thats obvious given the look of it :/). As of this PR, my tests not passing and I'd like more time to keep working on them and push up more.
Explain how VCR aids in testing an API.	The VCR is there to record a mock call to the API and give repeating set of criteria to test against so you don't have to use up your 5k calls!
What is the Heroku URL of your deployed application?	https://hungry-weirdo.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Testing/more live coding with this, or at least more time.

[kariabancroft]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Looks good
Comprehension questions	Yes
General
Rails fundamentals (RESTful routing, use of named paths)	I'm not sure that you're using them all, specifically /homepages/show and /recipes seem unnecessary.
Semantic HTML	Yes.
Errors are reported to the user	No - there is not user info on errors or handling of errors in the controller or api wrapper layer
API Wrapper to handle the API requests	Yes - What happens if the "hits" key isn't in the recipe response? What happens if the response doesn't have a first element?
Controller testing	Not really - I'd like to see you continue working through these with some support and then we should take another look in a week or two at your progress
Styling
Foundation Styling for responsive layout	Yes - list of recipes looks good and responsive
Search View	Good - it would be good to have something to show the user if no recipes found for the search
List View	Good
Show View which opens in a new tab	You have CSS (widths) directly in your HTML which you should not have. As you iterate over the nutrients, you are making a lot of assumptions about the data within the view. It'd be good to transform this data in the Recipe object so the view isn't relying on this data transformation.
API Features
The App attributes Edaman	Yes
The VCR casettes do not contain the API key	I don't see a cassette file
Overall	Overall you did a nice job with the required functionality on this project. There is still work to be done on testing which we will follow up on.