Queues Laura's api-muncher

[lmelgarejos]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	It took me a while to get familiar with the documentation, but after understanding it, it was very useful to target the requests. I think exploring the API was a bit overwhelming because it was the first time for me. I am positive that the next one it's going to be easier.
Describe your API Wrapper. How did you decide on the methods you created?	The API Wrapper is in the lib folder as recipes.rb. I decided to make two methods to get the required information on the road. My first thought was to minimize the number of queries to the web server, but I could not figured out how to pull the info for a single recipe from the info got in the list of recipes. The methods themselves were written with the help of postman looking how the response came.
Describe an edge case or failure case test you wrote for your API Wrapper.	I could not do it.
Explain how VCR aids in testing an API.	It does the request once and saves it for the each test, so you do not need to make a request for each one of them, and probably run out of free requests to the api.
What is the Heroku URL of your deployed application?	http://laus-api-muncher.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Perhaps more examples of tests.

[droberts-sea]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	mostly - there are several places you use <div> where <section> or <article> might be more informative
Errors are reported to the user	no - This should be one of the first things you do when you set up a new project (for example by adding code to display flash messages to application.html.erb). It will save you a lot of trouble in the long run.
API Wrapper to handle the API requests	yes - good work!
Controller testing	some - I would like to see more testing in general, both for controllers and for the lib files. Interesting questions that might be asked by your tests include "What happens if my search returns 0 results" and "What happens if I try to show a recipe that doesn't exist".
Styling
Foundation Styling for responsive layout	Foundation was included, but you're not making use of the grid layout. Please try to get some time in on this before we leave our Rails unit.
Search View	yes
List View	yes
Show View which opens in a new tab	yes
API Features
The App attributes Edaman	yes
The VCR casettes do not contain the API key	yes
Overall

Good work overall!