Alison, Aurora, Lynn, Jackie Debtsy / bEtsy

[auroralemieux]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	First we split up the work by controller, and did some pairing throughout. We all expressed interest in getting experience with specific features and divided features up that way.
How did your team utilize git to collaborate?	We used branches to isolate work in progress. We merged using git (not prs from github).
What did your group do to try to keep your code DRY while many people collaborated on it?	Clear communication before divvying stuff up really helped that. We spent most of the first day just planning and mapping everything out. Then after we had completed features we paired up to DRY some things up.
What was a technical challenge that you faced as a group?	OrderItems (should it be a join table or an independent model?) were a challenge we rethought early on. When to set and clear session was a challenge (for user_id and order_id).
What was a team/personal challenge that you faced as a group?	Some of us learned more about our own personal communication styles. Balancing who wanted to work on what / who was working on what / who wanted experience in what / etc was a good challenge.
What could your team have done better?	Divvying up the load of the tasks. It was hard to feel like things were shared evenly on the bigger things (cart, etc.).
What was your application's ERD? (include a link)	https://github.com/AlisonZ/betsy/blob/master/jollyowl-erd.pdf
What is your Trello URL?	https://trello.com/b/nqSf2RC8/debtsy-apocalypsy
What is the Heroku URL of your deployed application?	debtsy.herokuapp.com

[CheezItMan]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Everyone has commits, it seems like Lynn & Aurora have a lot more commits. It's hard to tell if their commits were just more granular, and their account may have been the ones used during pairing.
Answered comprehension questions	Good, OrderItem could either be a join table or an independent Model. It depend if you wanted it to have additional functionality beyond linking items and orders, like quantity.
Trello board is created and utilized in project management	Check
Heroku instance is online	Check
General
Nested routes follow RESTful conventions	Check
oAuth used for User authentication	Check
Functionality restricted based on user roles	Check, Merchant can't review items, and logged in users can manage their items and no others.
Products can be added and removed from cart	Check
Users can view past orders	Check for logged in users
Merchants can add, edit and view their products	Check
Errors are reported to the user	Decent use of flash messages
Order Functionality
Reduces products' inventory	Check
Cannot order products that are out of stock	Check
Changes order state	Check
Clears current cart	Check
Database
ERD includes all necessary tables and relationships	Check
Table relationships	Check
Models
Validation rules for Models	Check, although you should validate price so it can't be negative. I'm making money buying CheezIts now!
Business logic is in the models	Check, nice work!
Controllers
Controller Filters used to DRY up controller code	You have used controllers to DRY things up quite a bit.
Testing
Model Testing	You've got a good amount of model testing. As I noted there's no validation for negative prices. Otherwise it looks pretty good.
Controller Testing	Some additional testing of your helper methods is needed, but pretty good.
Session Testing	Missing some testing, for example logging out.
SimpleCov at 90% for controller and model tests	95% coverage, GREAT! Look like you need a bit more session testing, and some of your helper methods in controller testing, but very good.
Front-end
The app is styled to create an attractive user interface	It looks really good, it doesn't have trouble at alternate resolutions however. My phone doesn't like it much.
The app layout uses Foundation's Grid	Check
Content is organized with HTML5 semantic tags	In some places like cart.html.erb you used div instead of more meaningful tags, but you had quite a bit of semantic html.
CSS is DRY	The CSS is not really DRY. Their are a lot of CSS rules that are repeated.
Overall	Great work overall. The site is functional and attractive. It has minor issues, but they really are minor. You should all be proud of your work here!