Queue - Andrea Valliere, Erica Case, Ting Wong, Hyunji Kim - Betsy

[ricecakemonster]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	We discussed about it together. Each person spoke up and took the part they wanted to work on.
How did your team utilize git to collaborate?	Each person made her own branches worked on those branches. We merged all the branches together at the stand-up every morning.
What did your group do to try to keep your code DRY while many people collaborated on it?	Each person's work was unique, so it was more of individual thing to do.
What was a technical challenge that you faced as a group?	As a group, not much.
What was a team/personal challenge that you faced as a group?	Getting the work done before the deadline.
What could your team have done better?	Testing app functions more thoroughly and often.
What was your application's ERD? (include a link)	https://www.lucidchart.com/documents/view/60e4c2a7-906b-407e-8d2c-551aedc83a9a
What is your Trello URL?	https://trello.com/b/Egt3mmmS/betsy
What is the Heroku URL of your deployed application?	https://petsy-wetsy.herokuapp.com/ (Not up to date. It needs updating...)

[droberts-sea]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	yes
Answered comprehension questions	yes
Trello board is created and utilized in project management	yes
Heroku instance is online	yes
General
Nested routes follow RESTful conventions	yes
oAuth used for User authentication	yes
Functionality restricted based on user roles	While buttons to edit someone else's product don't exist, I was still able to type in the edit url for that product in the address bar and make changes. You need to make sure these actions are restricted based on who's logged in.
Products can be added and removed from cart	yes
Users can view past orders	yes
Merchants can add, edit and view their products	yes
Errors are reported to the user	yes
Order Functionality
Reduces products' inventory	yes
Cannot order products that are out of stock	yes, but it was not obvious why it couldn't be added to my order
Changes order state	yes
Clears current cart	yes
Database
ERD includes all necessary tables and relationships	yes
Table relationships	yes
Models
Validation rules for Models	yes
Business logic is in the models	yes
Controllers
Controller Filters used to DRY up controller code	yes
Testing
Model Testing	some - many tests are commented out (in Order for example), and some custom methods are untested (Product#default_image and Product#avg_rating for example)
Controller Testing	needs improvement - you have a good start at testing for a few controllers, but many tests are only stubbed in and some controllers are missing tests altogether. Remember that tests should be written by the person who built that feature, and that if a feature isn't tested, it isn't complete.
Session Testing	yes - would like a little more testing around authorization (who is allowed to do what) but otherwise looks good
SimpleCov at 90% for controller and model tests	no! 57.1%
Front-end
The app is styled to create an attractive user interface	Mostly. On some of the forms, the image overlaps the text boxes!
The app layout uses Foundation's Grid	yes
Content is organized with HTML5 semantic tags	yes
CSS is DRY	mostly - some of your colors are repeated many times, making them difficult to change. Is there a way you could consolidate these?
Overall

Good work overall. Make sure you focus on testing and following a good TDD work the last few weeks of Rails.