Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Lynn Trickey's Instructor Media Ranker #27

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@

# Ignore Byebug command history file.
.byebug_history

#adding ENV file
.env
6 changes: 6 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,17 @@ gem 'jbuilder', '~> 2.5'
# Use the Foundation CSS framework
gem 'foundation-rails'

#Adding OmniAuth
gem "omniauth"
gem "omniauth-github"

group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
gem 'byebug', platform: :mri

# Improve the error message you get in the browser
gem 'better_errors'
gem 'binding_of_caller'

# Use pry for rails console
gem 'pry-rails'
Expand All @@ -64,6 +69,7 @@ group :development do
# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
gem 'dotenv-rails'
end

# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
Expand Down
34 changes: 33 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ GEM
erubis (>= 2.6.6)
rack (>= 0.9.0)
bindex (0.5.0)
binding_of_caller (0.7.2)
debug_inspector (>= 0.0.1)
builder (3.2.3)
byebug (9.0.6)
coderay (1.1.1)
Expand All @@ -60,15 +62,23 @@ GEM
execjs
coffee-script-source (1.12.2)
concurrent-ruby (1.0.5)
debug_inspector (0.0.2)
dotenv (2.2.0)
dotenv-rails (2.2.0)
dotenv (= 2.2.0)
railties (>= 3.2, < 5.1)
erubis (2.7.0)
execjs (2.7.0)
faraday (0.11.0)
multipart-post (>= 1.2, < 3)
ffi (1.9.18)
foundation-rails (6.3.0.0)
railties (>= 3.1.0)
sass (>= 3.3.0, < 3.5)
sprockets-es6 (>= 0.9.0)
globalid (0.3.7)
activesupport (>= 4.1.0)
hashie (3.5.5)
i18n (0.8.1)
jbuilder (2.6.3)
activesupport (>= 3.0.0, < 5.2)
Expand All @@ -77,6 +87,7 @@ GEM
rails-dom-testing (>= 1, < 3)
railties (>= 4.2.0)
thor (>= 0.14, < 2.0)
jwt (1.5.6)
listen (3.0.8)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
Expand Down Expand Up @@ -104,9 +115,26 @@ GEM
minitest (~> 5.0)
rails (>= 4.1)
multi_json (1.12.1)
multi_xml (0.6.0)
multipart-post (2.0.0)
nio4r (2.0.0)
nokogiri (1.7.1)
mini_portile2 (~> 2.1.0)
oauth2 (1.3.1)
faraday (>= 0.8, < 0.12)
jwt (~> 1.0)
multi_json (~> 1.3)
multi_xml (~> 0.5)
rack (>= 1.2, < 3)
omniauth (1.6.1)
hashie (>= 3.4.6, < 3.6.0)
rack (>= 1.6.2, < 3)
omniauth-github (1.2.3)
omniauth (~> 1.5)
omniauth-oauth2 (>= 1.4.0, < 2.0)
omniauth-oauth2 (1.4.0)
oauth2 (~> 1.0)
omniauth (~> 1.2)
pg (0.20.0)
pry (0.10.4)
coderay (~> 1.1.0)
Expand Down Expand Up @@ -194,8 +222,10 @@ PLATFORMS

DEPENDENCIES
better_errors
binding_of_caller
byebug
coffee-rails (~> 4.2)
dotenv-rails
foundation-rails
jbuilder (~> 2.5)
jquery-rails
Expand All @@ -204,6 +234,8 @@ DEPENDENCIES
minitest-reporters
minitest-skip
minitest-spec-rails
omniauth
omniauth-github
pg (~> 0.18)
pry-rails
puma (~> 3.0)
Expand All @@ -220,4 +252,4 @@ RUBY VERSION
ruby 2.4.0p0

BUNDLED WITH
1.14.4
1.14.6
11 changes: 11 additions & 0 deletions app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,23 @@ class ApplicationController < ActionController::Base
protect_from_forgery with: :exception

before_action :find_user
before_action :require_login

def render_404
# DPR: supposedly this will actually render a 404 page in production
raise ActionController::RoutingError.new('Not Found')
end

def require_login
#see if user is logged in.
if !@login_user
#If not flash warning, redirect to root_path
flash[:status] = :failure
flash[:result_text] = "You must be logged in to do that"
redirect_to root_path
end
end

private
def find_user
if session[:user_id]
Expand Down
67 changes: 47 additions & 20 deletions app/controllers/sessions_controller.rb
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
class SessionsController < ApplicationController
def login_form
end
skip_before_action :require_login, only: [:create]

def create
auth_hash = request.env['omniauth.auth']

def login
username = params[:username]
if username and user = User.find_by(username: username)
session[:user_id] = user.id
flash[:status] = :success
flash[:result_text] = "Successfully logged in as existing user #{user.username}"
else
user = User.new(username: username)
if user.save
session[:user_id] = user.id
flash[:status] = :success
flash[:result_text] = "Successfully created new user #{user.username} with ID #{user.id}"
else
flash.now[:status] = :failure
flash.now[:result_text] = "Could not log in"
flash.now[:messages] = user.errors.messages
render "login_form", status: :bad_request
return
# look for user in db
user = User.find_by(uid: auth_hash["uid"], provider: auth_hash["provider"])

#if not there create a new user
if user.nil?
user = User.create_from_github(auth_hash)
if user.nil?
flash[:status] = :warning
flash[:result_text] = "Unable to login"
redirect_to root_path
end
end

#set sessions
session[:user_id] = user.id
flash[:status] = :success
flash[:result_text] = "Successfully logged in as #{ user.email }"
redirect_to root_path
end

Expand All @@ -31,4 +30,32 @@ def logout
flash[:result_text] = "Successfully logged out"
redirect_to root_path
end

# def login_form
# end
#
# def login
# username = params[:username]
# if username and user = User.find_by(username: username)
# session[:user_id] = user.id
# flash[:status] = :success
# flash[:result_text] = "Successfully logged in as existing user #{user.username}"
# else
# user = User.new(username: username)
# if user.save
# session[:user_id] = user.id
# flash[:status] = :success
# flash[:result_text] = "Successfully created new user #{user.username} with ID #{user.id}"
# else
# flash.now[:status] = :failure
# flash.now[:result_text] = "Could not log in"
# flash.now[:messages] = user.errors.messages
# render "login_form", status: :bad_request
# return
# end
# end
# redirect_to root_path
# end
#

end
23 changes: 19 additions & 4 deletions app/controllers/works_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ class WorksController < ApplicationController
# of work we're dealing with
before_action :category_from_url, only: [:index, :new, :create]
before_action :category_from_work, except: [:root, :index, :new, :create]
skip_before_action :require_login, only: [:root, :index, :show]

def root
@albums = Work.best_albums
Expand All @@ -22,6 +23,7 @@ def new

def create
@work = Work.new(media_params)
@work.user_id = @login_user.id
if @work.save
flash[:status] = :success
flash[:result_text] = "Successfully created #{@media_category.singularize} #{@work.id}"
Expand All @@ -39,6 +41,12 @@ def show
end

def edit
if @work.user_id != @login_user.id
#tell them they can't do it, redirect to root path?
flash[:status] = :failure
flash[:result_text] = "You can only edit a work that you created."
redirect_to root_path
end
end

def update
Expand All @@ -56,10 +64,17 @@ def update
end

def destroy
@work.destroy
flash[:status] = :success
flash[:result_text] = "Successfully destroyed #{@media_category.singularize} #{@work.id}"
redirect_to root_path
if @work.user_id != @login_user.id
#tell them they can't do it, redirect to root path?
flash[:status] = :failure
flash[:result_text] = "You can only delete a work that you created."
redirect_to root_path
else
@work.destroy
flash[:status] = :success
flash[:result_text] = "Successfully destroyed #{@media_category.singularize} #{@work.id}"
redirect_to root_path
end
end

def upvote
Expand Down
13 changes: 12 additions & 1 deletion app/models/user.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
class User < ApplicationRecord
has_many :votes
has_many :ranked_works, through: :votes, source: :work
has_many :works

validates :username, uniqueness: true, presence: true
# validates :username, presence: true, uniqueness: true

def self.create_from_github(auth_hash)
user = User.new
user.uid = auth_hash["uid"]
user.provider = auth_hash["provider"]
user.username = auth_hash["info"]["name"]
user.email = auth_hash["info"]["email"]

user.save ? user : nil #returns user object if true, nil if false
end
end
1 change: 1 addition & 0 deletions app/models/work.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
class Work < ApplicationRecord
has_many :votes, dependent: :destroy
has_many :ranking_users, through: :votes, source: :user
belongs_to :user

validates :category, presence: true,
inclusion: { in: %w(album book movie) }
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<%= link_to "Log Out", logout_path, method: :post, class: "button float-right" %>
<% else %>
<p class="text-right">Not logged in</p>
<%= link_to "Log In", login_path, class: "button float-right" %>
<%= link_to "Login using GitHub", "/auth/github" , class: "button float-right" %>
<% end %>
</div>
</header>
Expand Down
3 changes: 3 additions & 0 deletions config/initializers/omniauth.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Rails.application.config.middleware.use OmniAuth::Builder do
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email"
end
6 changes: 4 additions & 2 deletions config/routes.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
Rails.application.routes.draw do
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
root 'works#root'
get '/login', to: 'sessions#login_form', as: 'login'
post '/login', to: 'sessions#login'
# get '/login', to: 'sessions#login_form', as: 'login'
# post '/login', to: 'sessions#login'

get "/auth/:provider/callback", to: "sessions#create"
post '/logout', to: 'sessions#logout', as: 'logout'

# Build the category routes for albums, books and movies
Expand Down
7 changes: 7 additions & 0 deletions db/migrate/20170417221035_add_col_to_users.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class AddColToUsers < ActiveRecord::Migration[5.0]
def change
add_column :users, :uid, :integer, null:false
add_column :users, :provider, :string, null:false
add_column :users, :email, :string, null:false
end
end
5 changes: 5 additions & 0 deletions db/migrate/20170418174749_add_user_id_to_works_table.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddUserIdToWorksTable < ActiveRecord::Migration[5.0]
def change
add_column :works, :user_id, :integer, index:true
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddForeignKeyRestraintsToWorks < ActiveRecord::Migration[5.0]
def change
add_foreign_key :works, :users
end
end
7 changes: 6 additions & 1 deletion db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20170407164321) do
ActiveRecord::Schema.define(version: 20170418174933) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand All @@ -19,6 +19,9 @@
t.string "username"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.integer "uid", null: false
t.string "provider", null: false
t.string "email", null: false
end

create_table "votes", force: :cascade do |t|
Expand All @@ -39,8 +42,10 @@
t.datetime "updated_at", null: false
t.integer "vote_count", default: 0
t.integer "publication_year"
t.integer "user_id"
end

add_foreign_key "votes", "users"
add_foreign_key "votes", "works"
add_foreign_key "works", "users"
end
Loading