forked from AdaGold/rails-zoo
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addie's Rails Zoo #25
Open
add2point71dots
wants to merge
19
commits into
Ada-C7:master
Choose a base branch
from
add2point71dots:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails ZooWhat We're Looking For
|
another branch test change yay!
add2point71dots
force-pushed
the
master
branch
from
November 7, 2017 06:59
5e5a978
to
2426389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails Zoo
Congratulations! You're submitting your assignment!
Comprehension Questions
<li>
that I wanted to look "selected" for styling purposes. The way I did it leaves an empty class for the<li>
that isn't selected - is that considered acceptable? I originally had an if/else that would either put a<li class="selected">
or just<li>
, but that seemed messier.display: flex
on the body (along with a couple other things) and thenflex: 1
on main. Not 100% sure what those properties do, but I would like to play around with them more and find out!