Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haby's RailsZoo #33

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Haby's RailsZoo #33

wants to merge 17 commits into from

Conversation

habypsow
Copy link

@habypsow habypsow commented Apr 3, 2017

Rails Zoo

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words the Rails request/response cycle for viewing an animals detail page The browser sends a request to the routes, which accesses the controller for the show method , it goes to the model to access the specific id which goes back to the controller. The controller then accesses the view for the show method, and reroutes it back to the controller. The response is sent back from the controller to the browser.
Describe one area of Rails that you gained more clarity on with this assignment The fact that the routes have to be in a certain order, I kept getting errors without understanding why, and the fact that my routes were in the wrong order finally jumped back at me.
Is there a specific piece of code you'd like more feedback on? I realize that I did not style the pages accordingly, but if there's anything in my code that I could improve on, please let me know.
What is one aspect of this project that surprised you? My memory! It can be easy to miss a step or forget which model or controller goes singular or plural, and i tried to complete this assignment from my memory, but found myself double checking my work with my Tasklist assignment.

@kariabancroft
Copy link

Rails Zoo

What We're Looking For

Feature Feedback
Appropriate Git usage with no extraneous files checked in Yes
Answered comprehension questions Yes - glad you got some more practice and didn't forget everything you learned :-)
Naming conventions: controller is plural, model is singular Yes - the naming convention for the strong params method is the name of the object plus the _params. So it'd be more standard to name it animal_params instead.
Overall Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants