Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kelly Souza Rolodex #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Kelly Souza Rolodex #21

wants to merge 2 commits into from

Conversation

kellysouza
Copy link

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model controls the database, both the data and the the logic which controls the data.
How do Backbone Views compare to Rails controllers? Views are closer to Rails controllers than Rails Views, the logic of the controller lives in the backbone views
How do Backbone Events work in comparison to DOM events? Dom events are build into the browser while backbone events allow you to build event listeners into any object. The logic for the backbone events are built into the view.
What do you think of Backbone in comparison to raw JavaScript & jQuery? Backbone seems to simplify the the process of creating views and models while giving more power the manipulate them
Do you have any recommendations on how we could improve this project for the next cohort? no

@CheezItMan
Copy link

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene 2 commits?
Comprehension questions Check
Functionality
Created a Contact Model Check
Created a Rolodex Collection Check
Created a ContactView which renders an individual contact Check
ContactView responds to a click event when the user clicks on the contact Check
RolodexView created which renders the list of contacts Check
DOM Events handled for creating new Contacts Check
The RolodexView responds to custom Backbone event generated by ContactView to show the modal Check, interesting how you created a renderDetails function to render the Contact in the details modal. Could you have instead created a new ContactView instance and just passed in a different template?
Styling, Foundation grid layout Check
All dynamic content is rendered using an Underscore template Check
Overall Interesting how you hide the modal in app.js instead of in the RolodexView. Why do it there? I also notice you created an event for clicks in contact_view.js going to a function called, hideDetails which doesn't exist. Nice work, you satisfied all the requirements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants