-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theresa's Rolodex #23
base: master
Are you sure you want to change the base?
Conversation
…it to, will refactor in the morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not bad, just remember not to use raw jQuery in a view. Use this.$
instead to only select items within the view.
|
||
var application = new Application(); | ||
$('#contact-details').hide(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be in the document.ready handler.
}, | ||
contactDetails: function(contact) { | ||
$('#contact-details').empty(); | ||
$('#contact-details').show(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to show the modal after the contents are filled in to prevent a flash
effect when the modal is shown, if the browser is busy.
Also don't use raw JavaScript to select items in the view. Use this.$
instead.
ROLODEXWhat We're Looking For
|
ROLODEX
Congratulations! You're submitting your assignment!
Comprehension Questions