Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Elizabeth Deutsch - Rolodex #24

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

edeutschie
Copy link

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? Models in Backbone are similar to Models in Rails. Backbone Models can organize application data and business logic, load and save data to and from the server, and can trigger their own events when data changes. Collections are a kind of model. They are similar to an array in that they are ordered sets of models.
How do Backbone Views compare to Rails controllers? Backbone Views are like Rails controller in that they handler controller logic, but they also render data/models/collections for the user and listen for DOM and Model events. They are the middle person between the DOM and the Models/Collections.
How do Backbone Events work in comparison to DOM events? A DOM event is triggered by a user doing something on their end such as clicking a button (ex. "Save" for a contact in Rolodex). Backbone Events are what allow us to respond when something happens from the other direction - to a Model or Collection. Backbone events include update, change, add, remove, etc.
What do you think of Backbone in comparison to raw JavaScript & jQuery? I think Backbone is a great way to organize raw JavaScript & jQuery. It's much easier to follow the code when it is split between the view, model, and html files. Also, the event hashes are a great way to organize the functions and events that trigger them.
Do you have any recommendations on how we could improve this project for the next cohort?

@edeutschie edeutschie changed the title Elizabeth Deutsch - Queues - Rolodex Queues - Elizabeth Deutsch - Rolodex Jun 5, 2017
@PilgrimMemoirs
Copy link

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Commit more often
Comprehension questions Mostly good - review what models are responsible for, they do not handle events.
Functionality
Created a Contact Model Well Done
Created a Rolodex Collection Well Done
Created a ContactView which renders an individual contact Well Done
ContactView responds to a click event when the user clicks on the contact Well Done - Is the line "'click .contact-card': 'showContactInfo'" in you RolodexView necessary? (you're probably guessing 'no', which is correct. How come?) What code between your rolodexview and contactview make that line unnecessary?
RolodexView created which renders the list of contacts Well Done
DOM Events handled for creating new Contacts Well Done
The RolodexView responds to custom Backbone event generated by ContactView to show the modal Well Done
Styling, Foundation grid layout Mostly Good - looking at the DOM, notice an li is getting rendered inside of another li for the small contact cards in rolodex list. When you set a view's tagname to an element, like 'li', what does that do? Does the template for that view need that tag repeated again in the underscore template?
All dynamic content is rendered using an Underscore template Well Done
Overall
Submission meets expectations for this project. Well Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants