Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks - Jackie - Rolodex #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jackiewatanabe
Copy link

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? the backbone keeps track of data and triggers events when the data changes. You can set defaults and validate changes to the data in the model in Backbone
How do Backbone Views compare to Rails controllers? The views in backbone are similar to rails controllers in that it handles updating data as well as updating the DOM after data changes.
How do Backbone Events work in comparison to DOM events? backbone events update the DOM and backbone model based on DOM events
What do you think of Backbone in comparison to raw JavaScript & jQuery? Still kind of hazy on the role of Backbone....
Do you have any recommendations on how we could improve this project for the next cohort? It might help to explain in more detail which views should handle which click events, and which views should handle triggering vs listening, etc.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some notes in the code.

this.template = params.template;

this.listenTo(this.model, "update", this.render);
$('.modal-container').hide();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be this.$('.modal-container').hide();

Remember to avoid raw jQuery in a view.

@@ -64,3 +64,12 @@ header {
.contact-card:hover h3 {
color: white;
}

.modal-container {
Copy link

@CheezItMan CheezItMan Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever to do it this way so your View picks up the click to hide it.

@CheezItMan
Copy link

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Decent # of commits, but could be more granular
Comprehension questions Check, and I'll take note of a discussion about what views respond to which events.
Functionality
Created a Contact Model Check
Created a Rolodex Collection Check
Created a ContactView which renders an individual contact Check
ContactView responds to a click event when the user clicks on the contact Check
RolodexView created which renders the list of contacts Check
DOM Events handled for creating new Contacts Check, good use of
The RolodexView responds to custom Backbone event generated by ContactView to show the modal Good use of trigger to show the modal. Interesting how you created the modal div to be the entire viewport to detect the click and hide itself. Took me a bit to figure out how the ContactDetailsView picked up the event. It works well.
Styling, Foundation grid layout Check
All dynamic content is rendered using an Underscore template Check
Overall Nice work, I like the use of the ContactDetailsView for the Modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants