Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alena's Rolodex #34

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Alena's Rolodex #34

wants to merge 13 commits into from

Conversation

Spatterjaaay
Copy link

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? Model initializes objects with attributes that we can specify and set defaults to them and validate them.
How do Backbone Views compare to Rails controllers? Backbone views have a similar function to controllers in Rails. They are the middle man that coordinates between templates and DOM and data/models. It's their task to update data and also tell DOM to display the changed data. It can also listen to DOM events or Backbone events and act on them.
How do Backbone Events work in comparison to DOM events? Dom events are events in which user interacts with the DOM (such as click, keypress etc). Backbone can listen to those, but it also listens, for example, to changes to the model, so it can display them. Backbone events can be custom events that are emitted by different Backbone objects.
What do you think of Backbone in comparison to raw JavaScript & jQuery? I do think it organizes the code better, but at the same time trying to keep track of the flow of what is responding to what and where is quite challenging. I'll be happy to get more practice with Backbone and solidify my understanding that way.
Do you have any recommendations on how we could improve this project for the next cohort? I think it was interesting to introduce the project gradually, and the live code was a life saver! So not really :)

template: that.detailsTemplate
});
detailsView.render();
that.$("#contact-details").html(detailsView.render().el);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be calling render twice here.

@CheezItMan
Copy link

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good # of commits
Comprehension questions The Model keeps track of the application data and business logic and also handles communicating back and forth to the API or permanent storage.
Functionality
Created a Contact Model Check
Created a Rolodex Collection Check
Created a ContactView which renders an individual contact Check
ContactView responds to a click event when the user clicks on the contact Check
RolodexView created which renders the list of contacts Check
DOM Events handled for creating new Contacts Check
The RolodexView responds to custom Backbone event generated by ContactView to show the modal Check, although I noted that you do call render on the detailsView twice.
Styling, Foundation grid layout Check
All dynamic content is rendered using an Underscore template Check
Overall Nice work, you hit all the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants