Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Allison - Rolodex #47

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Allison-Northrop
Copy link

ROLODEX

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model in backbone is similar to a class. So for example, the contact model acts as a class that has the attirbutes phone, name and email.
How do Backbone Views compare to Rails controllers? The Backbone Views are similar to controllers in that the functions that deal with the data are written and dealt with in the views.
How do Backbone Events work in comparison to DOM events? Backbone events occur when something on the database is changed. DOM events are just something that occurs when a user does something.
What do you think of Backbone in comparison to raw JavaScript & jQuery? To be honest, I'm super confused by it. I was really loving JavaScript and Jquery, so perhaps I just need more practice utilizing backbone. This was not my finest project...
Do you have any recommendations on how we could improve this project for the next cohort? I thought the instructions were really confusing -especially how it has us writing one thing and then going back and doing something else instead.

@PilgrimMemoirs
Copy link

ROLODEX

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Should commit more often
Comprehension questions Almost, be more specific - 1) they handle the data 2) connects model (specifically) with views 3) We haven't worked with a database yet, but it does respond to data that is changed
Functionality
Created a Contact Model Well Done
Created a Rolodex Collection Well Done
Created a ContactView which renders an individual contact Mostly Good - See note below on templates
ContactView responds to a click event when the user clicks on the contact Mostly Good - See note below on templates
RolodexView created which renders the list of contacts Well done
DOM Events handled for creating new Contacts ❗️ Incomplete - You're actually pretty close, All you have to do is two things. First, make sure you are passing the input from the form into the 'form' object. Notice how you are first creating the empty object after you get the values from the form, that results in returning an empty object and the line this.model.add(form) can't do anything with that. Instead of defining the form as empty, do this instead ` var form = {name: name, email: email, phone_number: phone};
` to pass the data collected from the form. Second thing you have to do is make sure you are getting the values from the form input fields, which you currently are not. In the JS there is an assumption the input fields have id - but looking at the html there aren't any. After you give those input elements ids, that match your jquery selectors, everything should work!
The RolodexView responds to custom Backbone event generated by ContactView to show the modal
Styling, Foundation grid layout Almost - looking at the dom, the
  • elements are nested in another
  • , with the innermost having the foundation styles that should have the small contact cards inline with each other - the contact
  • All dynamic content is rendered using an Underscore template
    Overall
    Some confusion may have been happening with the templates, I see there are two, but it appears the same is being used for the list of contacts as well as the details. The list should only display a name, and the module should show all the details. Looking at the id's of both templates, tmpl-contact-details doesn't appear to be used but seems like it should be for the module. Instead, tmpl-contact-card is being used for both and is causing the strange layout.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants