Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lauren Cardella -- Carets #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

enigmagnetic
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I got a bunch of warnings about not using headers as the first element in a section or article, and warnings on each page for the meta data and fonts links. Since the first instance was a stylistic choice and the fonts seem to be working fine, I didn't make any changes.
Why is it important to consider and use semantic HTML? It makes your site more accessible by indicating to screen readers the purpose of the content according to its semantic tag.
How did you decide to structure your CSS? I put all the general element tags at the very top of the document, then added styles for each page according to its place in the navigation, and then individual page styles according to where the element appears on the HTML page, from top to bottom.
What was the most challenging piece of this assignment? For me writing the CSS felt very time-consuming, making an adjustment and then checking the changes before making any more.
Describe one area that you gained more clarity on when completing this assignment It was good to have practice styling images that are embedded in the HTML.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Very few commits. The messages are good however.
Answered comprehension questions Headers as the 1st element of a section are used by automated programs reading your page (google web crawler for example) to identify what the section is about.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main Nicely done!
Appropriately using semantic tags: section, article, etc. Check, although a noted by the validator sections are normally followed by a header to identify the purpose of the section.
All images include alternate text Yep!
CSS
Using class and ID names in style declarations You are using a lot of these, are they all necessary? Do you need a class for yellow?
Style declarations are DRY Some repeated declarations are there, like text-align: center, but not too many. That's a very minor quibble.
Overall Nicely done. You hit all the requirements and produced a neat site with simple and elegant style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants