Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Lindsey - Static Site #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

VirtualLindsey
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Accidentally having un-closed tags.
Why is it important to consider and use semantic HTML? So it's easier to maintain the code, and for other people to update it if the original author isn't available.
How did you decide to structure your CSS? I did it from the top of the page down then added additional CSS to other pages below.
What was the most challenging piece of this assignment? Getting CSS to do what I wanted it to do
Describe one area that you gained more clarity on when completing this assignment How floats behave and how to work with them.

@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes - Regarding the second question, in addition to being a valuable tool for developers, semantic HTML is important for assistive technologies like screen readers.
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main some - I like that I see <header> and <footer> tags, but it looks like you wrap the main content of each page in a <div> when a <main> might be more semantic.
Appropriately using semantic tags: section, article, etc. no - lots of <div>, even where an <article> or <section> would be more appropriate (like on the code journal page with header "Articles").
All images include alternate text no - Alt text is important both if the image doesn't load and as something for accessibility tools to work with. Adding it to all images is a requirement in this course.
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Site is attractive and easy to navigate - good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants