Pipes - Kate Evans-Spitzer and Tanisha Hampden - Video Store API

[Guribot]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We generally took the attributes for each model from the seed data, as well as the requirements in the README. We decided that the Rentals model would work best as a join table between Movies and Customers.
Describe a set of positive and negative test cases you implemented for a model.	Positive: Check that our attributes default properly where necessary (e.g. rental due date defaults to 3 days after checkout) // Negative: Confirms the numericality of the movie inventory (can't be "dog")
Describe a set of positive and negative test cases you implemented for a controller.	Positive: Can create a new rental in the database // Negative: Returns "bad request" if rental cannot be created
How does your API respond when bad data is sent to it?	Usually sends "bad request", unless the bad data is an ID that doesn't exist, in which case it sends "not found"
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	All 3 of our models use model methods "set_defaults" to set their default values after initialization.
Do you have any recommendations on how we could improve this project for the next cohort?	The serialization troubles were tricky, but otherwise it was a nicely paced project for this short week
Link to Trello	https://trello.com/invite/b/zWE9aV8Q/a46c0b6c4129e668dcf22a32a5f26a0d/video-store
Link to ERD	https://trello.com/c/BO8Zz7yz

[PilgrimMemoirs]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Well Done - thanks for the feedback!
General
Business Logic in Models	Mostly Good - logic for setting due date should be in model, not controller.
All 3 required endpoints return expected JSON data	Well Done
Requests respond with appropriate HTTP Status Code	Well Done
Errors are reported	Well Done
Testing
Passes all Smoke Tests	Well Done
Model Tests - all relations, validations, and custom functions test positive & negative cases	Mostly Good - check_out_count should test that count increases when a customer has checked out a movie.
Controller Tests - URI parameters and data in the request body have positive & negative cases	Well Done
Optionals
POST routes use URI parameter and request body to add a new record to the database	Well Done - appropriate use of body params to send data
GET /customers shows how many movies are checked out by a customer	Well Done
GET /movies/:id shows updated inventory	Well Done
Overall
	Great Work! Submission meets project expectations.