Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackie - Ampers #27

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Jackie - Ampers #27

wants to merge 5 commits into from

Conversation

Jackiesan
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to use a reduce enumerable to find the highest scoring word. I also used loops to iterate through an array of words and return their scores.
What was a challenge you faced in this assignment? My indentation is off and I can't quite figure out how to fix it. It was challenging to get used to the JS syntax.
Do you have any recommendations on how we could improve this project for the next cohort? I actually thought it was a great project to start off with.

@tildeee
Copy link

tildeee commented May 23, 2018

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

Jackie!! This code is so good!! Oh my goodness!! It's fantastic!

I loved how you used filter, Math.max, some, reduce. They make the code really concise.

You should be very proud of this solution! I think it shows that you're really trying some cool stuff and getting deep into JavaScript.

Wonderful work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants