Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&& Brittany Jones Ampers #36

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

brittanyrjones
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to look at my old scrabble projects, and just look at the methods that we wrote as a guidline for the functions I wanted to do in this project. The testing structure is also similar.
What was a challenge you faced in this assignment? This project had the challenge of learning JS syntax. I got tripped up with some issues with semicolons, brackets, and parens, and which order to put them in. I think It would have helped to first focus on getting the structure down, and then adding my code.
Do you have any recommendations on how we could improve this project for the next cohort? I think this was a good project. It was not so simple, and there are a lot of opportunities for problem solving. It was also fun to look back on an old project and reuse some of it.

@tildeee
Copy link

tildeee commented May 23, 2018

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

Good work!

I liked the helper functions you made, like valid()

Your indentation was off in a lot of places

Also, I saw you commented out a test

Other than that, looks great!

},
};

Scrabble.Player = class {

constructor(name = isRequired('name')) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What were you trying to do here?

// this._highestWordScore = 0;
}

plays(arrayOfWords) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function isn't being used -- feel free to delete it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants