Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brandy Austin - JS Scrabble - Octos #45

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

brandyaustinseattle
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to apply my knowledge of breaking the code into small pieces and using helper methods where possible.
What was a challenge you faced in this assignment? I spent a lot of time trying to figure out why two tests weren't passing when I was missing () at the end of a function. It was challenging to spot this missing syntax.
Do you have any recommendations on how we could improve this project for the next cohort? I think it would be feasible to make the requirements a little more intense. This seemed like a fast project.

@droberts-sea
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
General
score calculates score, has appropriate params and return value yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value yes
Player object
Has name and plays properties yes
Has play, totalScore, hasWon functions yes
Has highestScoringWord and highestWordScore functions yes
Overall Excellent work overall!

const scoreTable = {
'a': { 'points': 1, 'tiles': 9 },
'b': { 'points': 3, 'tiles': 2 },
'c': { 'points': 3, 'tiles': 2 },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you've consolidated the points and number of tiles into one data structure - clever thinking!

const checkArrayOfWords = function checkArrayofWords(arrayOfWords) {
if (arrayOfWords.length === 0) {
throw "List of words cannot be empty";
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of helper functions through here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants