Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Angela Poland #23

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

AngelaPoland
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? The application will continue running even while calls are being made to the API.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? When getting trip details, while loading there is a message that they are loading...this can happen without reloading the entire list of all trips but the code happens after the entire list is executed.
What kind of errors might the API give you? How did you choose to handle them? There are .catch errors for the possibility of not being able to show the entire list of trips or a specific trip's details.
Do you have any recommendations on how we could improve this project for the next cohort? more hints as to how this project was different from what we did in class to ramp up for this assignment.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits, most of your commit messages are good (baby steps?) :p
Comprehension questions Check, we'll keep the hints in mind.
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check, good work reporting the validation errors!
Styling It looks good, but it's not a responsive design. Something to work on.
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read Check
HTML is semantic Check, good semantic HTML
Overall Excellent work! You hit all the learning goals. The site looks good and all the API code works as advertised. One thing to improve is the responsiveness on small screens. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants