-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
&&: Monalisa's trek #33
base: master
Are you sure you want to change the base?
Conversation
}); | ||
$('.trip-item').click( function(event) { | ||
loadTripDetails(`${event.target.id}`); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ends up working, but we would prefer if you added your click event listener to each .trip-item
using event delegation
|
||
axios.post(URL + '/' + tripId + '/reservations', reserveData) | ||
.then((response) => { | ||
reportStatus(`Successfully reserved ${tripId}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ends up not being a very helpful message if you put in the tripId
since it just ends up reading "Successfully reserved 4" or whatever the trip ID is. It might be more usable if you put in the trip's name instead.
TREKWhat We're Looking For
I think these projects are an opportunity to be creative with styling, but I must warn against using blinking animations... it's not very good on text that needs to display important information to the user, because the user cannot read it well or focus on it well. I understand that it draws the attention of the user and looks flashy, but it's not very usable. Why does your reservation form show up at the very beginning? Otherwise, good work, the code works well and it's good overall |
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions