Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers Steffany #42

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Ampers Steffany #42

wants to merge 15 commits into from

Conversation

steffnay
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that the event or action doesn't interrupt the flow of the program
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The trip list and trip details don't appear until triggered by a click. This changed the way that I structured my code because it caused me to use the .on('click') rather than .click for the events that need to be updated and then triggered.
What kind of errors might the API give you? How did you choose to handle them? It might return bad request when there is a name or email missing.
Do you have any recommendations on how we could improve this project for the next cohort? No, I think it was done well.

})
.catch((error) => {
console.log(error.response);
if (error.response.data && error.response.data.errors) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indentation here started to confuse me a little! small comment

const tripDescription = $('#description');
tripDescription.empty();
const tripCategory = $('#category');
tripName.empty();
Copy link

@tildeee tildeee May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably meant tripCategory.empty(); here? also below you have another copy/paste of tripName

@tildeee
Copy link

tildeee commented May 29, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Functionality
Click a button to list trips x
Click a trip to see trip details x
Fill out a form to reserve a spot i didn't see any UI change to indicate that it worked, but it worked!
Errors are reported to the user x
Styling x
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Good work! The code looks good and your styling looks great (even though you mentioned CSS is a weird challenge, you did a good job with this!)

Everything worked really well in general. Great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants