Make empty identifiers a fatal error

Ref. #892
AdaCore · Jan 5, 2022 · a46bef2 · a46bef2
1 parent 8dc0e4f
commit a46bef2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/rflx/identifier.py b/rflx/identifier.py
@@ -1,7 +1,7 @@
 import re
 from typing import Optional, Sequence, TypeVar, Union
 
-from rflx.error import Location, RecordFluxError, Severity, Subsystem
+from rflx.error import Location, RecordFluxError, Severity, Subsystem, fatal_fail
 
 Self = TypeVar("Self", bound="ID")
 
@@ -25,7 +25,7 @@ def __init__(
 
         error = RecordFluxError()
         if not self._parts:
-            error.extend([("empty identifier", Subsystem.ID, Severity.ERROR, location)])
+            fatal_fail("empty identifier", Subsystem.ID, Severity.ERROR, location)
         elif "" in self._parts:
             error.extend(
                 [(f'empty part in identifier "{self}"', Subsystem.ID, Severity.ERROR, location)]

diff --git a/tests/unit/identifier_test.py b/tests/unit/identifier_test.py
@@ -1,6 +1,6 @@
 import pytest
 
-from rflx.error import RecordFluxError
+from rflx.error import FatalError, RecordFluxError
 from rflx.identifier import ID
 
 
@@ -20,7 +20,7 @@ def test_id_invalid_type() -> None:
 
 
 def test_id_invalid_empty() -> None:
-    with pytest.raises(RecordFluxError, match=r"^id: error: empty identifier$"):
+    with pytest.raises(FatalError, match=r"^id: error: empty identifier$"):
         ID([])
 
 
@@ -107,7 +107,7 @@ def test_id_parent() -> None:
 
 
 def test_id_parent_error() -> None:
-    with pytest.raises(RecordFluxError, match=r"^id: error: empty identifier$"):
+    with pytest.raises(FatalError, match=r"^id: error: empty identifier$"):
         ID("A").parent  # pylint: disable=expression-not-assigned