Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the GNATCOLL_ICONV_OPT environment variable when installing RecordFlux #1289

Closed
dalybrown opened this issue Sep 30, 2023 · 1 comment

Comments

@dalybrown
Copy link

The following line was causing me issues when installing RecordFlux via pip:

https://github.com/AdaCore/RecordFlux/blob/ca7f2ee9aa7bdf8552cdc32892a9da3a16b340e3/setup.py#L30C21-L30C21

I had to build gnatcoll_iconv.gpr myself separately (the static-pic library) in order to set the GNATCOLL_ICONV_OPT environment variable such that the symbols are found on my system.

Perhaps instead of setting the value directly, it could be a default value so that users can set it according to their system if required so that when installing RecordFlux the version of gnatcoll_iconv that comes bundled with it is built properly.

adacore-bot pushed a commit that referenced this issue Oct 24, 2023
ref #1289
ref eng/recordflux/RecordFlux#1437
@treiher
Copy link
Collaborator

treiher commented Oct 25, 2023

Thank you for the report! This issue has been fixed and will be part of the next release (0.15.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants