-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken message bit index calculation #503
Comments
jklmnn
changed the title
PyRFLX: Fix bitindex calculation
Broken message bit index calculation
Nov 26, 2020
Merged
As discussed |
jklmnn
added a commit
that referenced
this issue
Dec 1, 2020
jklmnn
added a commit
that referenced
this issue
Dec 1, 2020
jklmnn
added a commit
that referenced
this issue
Dec 1, 2020
jklmnn
added a commit
that referenced
this issue
Dec 1, 2020
jklmnn
added a commit
that referenced
this issue
Dec 3, 2020
jklmnn
added a commit
that referenced
this issue
Dec 4, 2020
jklmnn
added a commit
that referenced
this issue
Dec 4, 2020
Fixed with #501. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the bitindex of a field in a message is calculated inconsistently depending on the context. Most calculations calculate the index of a field by the predecessors first and length. They usually rely on
Initial'First
being set which is set to 0 in the constructor. This creates two problems:This results in all calculations made with
Initial'First
being incompatible toMessage'First
Since
Initial'First
is used as base any change toMessage'First
by the model might be ignored, and if it is not the results of many calculations are probably wrongTo fix this
Initial'First
should be set toMessage'First
and a mechanism is needed to detect ifMessage'First
has been set in the message and to use either this or the default value 1.The text was updated successfully, but these errors were encountered: