Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fully qualified type names #1009

Merged
merged 10 commits into from
May 10, 2022
Merged

Use fully qualified type names #1009

merged 10 commits into from
May 10, 2022

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented May 5, 2022 •
edited
Loading

Supersedes #1007.

  • Use fully qualified type names in message fields
  • Add necessary with clauses to resolve imports

@rami3l rami3l mentioned this pull request May 5, 2022
Closed
@rami3l rami3l force-pushed the fix/qualification branch 5 times, most recently from 76219a1 to c419351 Compare May 6, 2022 10:48
@rami3l rami3l marked this pull request as ready for review May 6, 2022 12:37
@rami3l rami3l requested a review from treiher May 6, 2022 12:37
treiher
treiher requested changes May 9, 2022
View reviewed changes
rflx/model/message.py Outdated Show resolved Hide resolved
rflx/model/model.py Outdated Show resolved Hide resolved
rflx/model/model.py Outdated Show resolved Hide resolved
rami3l
rami3l commented May 9, 2022
View reviewed changes
rflx/model/type_.py Outdated Show resolved Hide resolved
@rami3l rami3l force-pushed the fix/qualification branch 5 times, most recently from 82f4c1c to 96fcc5f Compare May 10, 2022 07:22
@rami3l rami3l requested a review from treiher May 10, 2022 08:23
@treiher treiher force-pushed the fix/qualification branch from 96fcc5f to 8ccbe74 Compare May 10, 2022 09:15
treiher
treiher requested changes May 10, 2022
View reviewed changes
tests/unit/model/model_test.py Outdated Show resolved Hide resolved
@rami3l rami3l force-pushed the fix/qualification branch from e06248e to 754396b Compare May 10, 2022 09:56
@rami3l rami3l requested a review from treiher May 10, 2022 09:57
@rami3l rami3l merged commit 8f1a273 into main May 10, 2022
@rami3l rami3l deleted the fix/qualification branch May 10, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treiher treiher treiher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rami3l @treiher