Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-free algorithms like SIFT and SURF causing tests to fail. #20

Closed
RobRoseKnows opened this issue Sep 16, 2018 · 2 comments
Closed

Non-free algorithms like SIFT and SURF causing tests to fail. #20

RobRoseKnows opened this issue Sep 16, 2018 · 2 comments
Assignees
@AdamSpannbauer
Milestone
release to pypi

Comments

@RobRoseKnows
Copy link

See opencv/opencv-python#126. As of OpenCV 3.4.3, the patented algorithms such as SIFT and SURF are hidden behind the OPENCV_ENABLE_NONFREE=1 flag. They are no longer included in the Python bindings which is causing the tests to fail on Travis.

Possible options are:

  • Remove SIFT and SURF from the tests
  • Add try-except logic in kp_method initialization to raise a warning when SIFT and SURF are used.
@AdamSpannbauer AdamSpannbauer self-assigned this Sep 23, 2018
@AdamSpannbauer
Copy link
Owner

Thanks for the catch, I had forgotten to turn on a recurring Travis build (turned on now).

Fix to come.

AdamSpannbauer added a commit that referenced this issue Sep 23, 2018
@AdamSpannbauer
drop SIFT & SURF from tests per #20
4f6a1d2
AdamSpannbauer added a commit that referenced this issue Sep 23, 2018
@AdamSpannbauer
Merge pull request #21 from AdamSpannbauer/non_free
1d9fd4b 
fix tests failing from non-free SIFT/SURF kp_methods (#20)
@AdamSpannbauer
Copy link
Owner

SIFT and SURF dropped from tests and a note about them has been added to the docs

thanks again for the catch @RobRoseKnows

@AdamSpannbauer AdamSpannbauer added this to the release to pypi milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamSpannbauer AdamSpannbauer

Labels
None yet
Projects
None yet
Milestone
release to pypi
Development

No branches or pull requests
2 participants
@RobRoseKnows @AdamSpannbauer