fix: adm node minVersion

Adamant-im · Feb 29, 2024 · a8eef25 · a8eef25
1 parent da8359c
commit a8eef25
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/src/config/development.json b/src/config/development.json
@@ -49,7 +49,7 @@
         "onScreenUpdateInterval": 10000,
         "threshold": 10
       },
-      "minVersion": "0.8.0"
+      "minVersion": "v0.8.0"
     },
     "services": {
       "list": {
@@ -218,4 +218,4 @@
     "explorer": "https://liskscan.com",
     "explorerAddress": "https://liskscan.com/account/${ID}"
   }
-}
+}
diff --git a/src/config/production.json b/src/config/production.json
@@ -48,7 +48,7 @@
         "onScreenUpdateInterval": 10000,
         "threshold": 10
       },
-      "minVersion": "0.8.0"
+      "minVersion": "v0.8.0"
     },
     "services": {
       "list": {
@@ -218,4 +218,4 @@
     "explorer": "https://liskscan.com",
     "explorerAddress": "https://liskscan.com/account/${ID}"
   }
-}
+}
diff --git a/src/config/test.json b/src/config/test.json
@@ -49,7 +49,7 @@
         "onScreenUpdateInterval": 10000,
         "threshold": 10
       },
-      "minVersion": "0.8.0"
+      "minVersion": "v0.8.0"
     },
     "services": {
       "list": {

diff --git a/src/config/tor.json b/src/config/tor.json
@@ -24,7 +24,7 @@
         "onScreenUpdateInterval": 10000,
         "threshold": 10
       },
-      "minVersion": "0.8.0"
+      "minVersion": "v0.8.0"
     },
     "services": {
       "list": {
@@ -178,4 +178,4 @@
     "explorer": "https://liskscan.com",
     "explorerAddress": "https://liskscan.com/account/${ID}"
   }
-}
+}
diff --git a/src/lib/nodes/abstract.node.ts b/src/lib/nodes/abstract.node.ts
@@ -204,7 +204,7 @@ export abstract class Node<C = unknown> {
     if (!this.minNodeVersion) {
       return true
     }
-
+    //TODO: If check the minimum version of Ethereum, you need to override the method and parse the client name in the version
     return this.version >= this.minNodeVersion
   }
 

diff --git a/src/lib/nodes/adm/AdmNode.ts b/src/lib/nodes/adm/AdmNode.ts
@@ -31,7 +31,7 @@ export class AdmNode extends Node {
   client: AxiosInstance
 
   constructor(url: string, minNodeVersion = '0.0.0') {
-    super(url, 'adm', 'node', NODE_LABELS.AdmNode, minNodeVersion, minNodeVersion)
+    super(url, 'adm', 'node', NODE_LABELS.AdmNode, '', minNodeVersion)
 
     this.wsPort = '36668' // default wsPort
     this.wsProtocol = this.protocol === 'https:' ? 'wss:' : 'ws:'