Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preserve message text in the input field #537

Merged
merged 6 commits into from
Nov 2, 2023
Merged

feat: preserve message text in the input field #537

merged 6 commits into from
Nov 2, 2023

Conversation

juliahermak
Copy link
Member

@juliahermak juliahermak commented Oct 6, 2023 •
edited
Loading

after.Preserve.message.text.in.the.input.field.webm

@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 10:22pm

bludnic
bludnic requested changes Oct 6, 2023
View reviewed changes
src/components/AChat/AChatForm.vue Outdated Show resolved Hide resolved
src/components/Chat/Chat.vue Outdated Show resolved Hide resolved
@bludnic
Copy link
Member

bludnic commented Oct 6, 2023

Feat: Preserve message text in the input field, if it was not sent

@bludnic bludnic changed the base branch from master to dev October 6, 2023 04:23
@bludnic bludnic requested a review from adamant-al October 6, 2023 04:23
adamant-al
adamant-al requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the custom-case solution.
We have validateMessage method.
Also, consider moving magic numbers to constants.
Refactor code, if appropriate.

@bludnic
Copy link
Member

bludnic commented Oct 13, 2023

I don't like the custom-case solution. We have validateMessage method. Also, consider moving magic numbers to constants. Refactor code, if appropriate.

I need to think about how to make the validation in one place and share it between Chat and AChatForm component, then I will came with a solution

@bludnic
Copy link
Member

bludnic commented Nov 2, 2023

  • Added validator prop for AChatForm
  • Replaced harcoded fee from constants

@adamant-al

@bludnic bludnic requested a review from adamant-al November 2, 2023 01:32
@bludnic bludnic mentioned this pull request Nov 2, 2023
Merged
@bludnic bludnic requested a review from martiliones November 2, 2023 11:30
@bludnic bludnic requested a review from martiliones November 2, 2023 14:31
@bludnic bludnic merged commit 4093d20 into Adamant-im:dev Nov 2, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bludnic bludnic bludnic approved these changes

@martiliones martiliones martiliones approved these changes

@adamant-al adamant-al Awaiting requested review from adamant-al

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliahermak @bludnic @martiliones @adamant-al