-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tor configuration #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # specification/openapi.json
bludnic
requested review from
martiliones,
confleux,
adamant-al and
StanislavDevIOS
October 13, 2023 19:43
Merged
martiliones
approved these changes
Oct 14, 2023
adamant-al
requested changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We forgot about coin tor nodes, add them.
just-software-dev
approved these changes
Oct 16, 2023
just-software-dev
approved these changes
Oct 16, 2023
adamant-al
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Suggest to set
minNodeVersion
to at least0.7.0
. - We suppose infoService's
alt_ip
's default port is 80. - Consider to add btcnode2 + alt_ip + tor, it's working
- Consider to add dogenode2 + alt_ip + tor, it's working
- Consider to add ethnode2 + alt_ip + tor, it's working
- Dash's node2 and node3 are on the way soon @confleux
We can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
explorer
URL for TornodeMinVersion
website
for TornodeMinVersion
README.md
. Add Tor examples.serviceNodes
toservices
(see lisk config @StanislavDevIOS)Use https://editor.swagger.io/ if you want to test the Swagger schema