Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dataloader constructor for piaf dataset. #93

Merged
merged 7 commits into from
Jun 9, 2024
Merged

Conversation

Davidyz
Copy link
Collaborator

@Davidyz Davidyz commented Jun 6, 2024

No description provided.

Copy link
Collaborator

@Willmish Willmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment about the potential need to change the verb repondre to noun reponse

prompt = examples["context"][i] + " " + examples["question"][i]
response = examples["answers"][i]["text"][0]

text = f"### Question: {prompt}\n ### Répondre: {response}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repondre or Reponse (verb "Answer" vs noun "Answer")

@Davidyz Davidyz merged commit afbb8c5 into main Jun 9, 2024
1 check passed
@Davidyz Davidyz deleted the david/piaf branch June 9, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants