Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to package reference #736

Closed
Barsonax opened this issue Jul 28, 2019 · 1 comment
Closed

Consider switching to package reference #736

Barsonax opened this issue Jul 28, 2019 · 1 comment
Labels
DevTool Area: Development tools and environment Task ToDo that's neither a Bug, nor a Feature
Milestone

Comments

@Barsonax
Copy link
Member

Barsonax commented Jul 28, 2019

Summary

Consider migrating all projects to package reference. This is already done with success on my netstandard branch (https://github.com/Barsonax/duality/tree/feature/netstandard_barsonax)

To do this you can either look at my branch for the needed changes or use the migration tool. The latter does a good job of migrating. One thing you do need to do manually is to modify the Copy tasks a bit. Taken from #573:

For this I found a solution since the buildoutput is no longer copied to the build output folder with package reference:

Add GeneratePathProperty="true" on the packagereference: https://github.com/Barsonax/duality/blob/feature/netstandard_barsonax/Source/Core/Duality/Duality.csproj#L11
You can now use $(PkgPackageNameWithUnderscoresInsteadOfDots) to refer to the package path:
https://github.com/Barsonax/duality/blob/feature/netstandard_barsonax/Source/Core/Duality/Duality.csproj#L97

After this is done we also need to update my netstandard branch to solve the conflicts that will arise.

Analysis

  • Needed for our transition to netstandard Switch From PCLs to .NET Standard #573
  • Makes the changes we have to do on the netstandard branch smaller
  • Cleaner project structure, with packagereference you don't need a separate package.config anymore than can get out of sync with the csproj.
  • Faster restores due to the use of the global nuget packages folder
@ilexp ilexp added DevTool Area: Development tools and environment Task ToDo that's neither a Bug, nor a Feature labels Jul 28, 2019
@ilexp ilexp added this to the C# / .NET Upgrade milestone Jul 28, 2019
@ilexp
Copy link
Member

ilexp commented Aug 10, 2019

Addressed in #739. Closing this.

@ilexp ilexp closed this as completed Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevTool Area: Development tools and environment Task ToDo that's neither a Bug, nor a Feature
Development

No branches or pull requests

2 participants