Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated all projects to packagereference #739

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Migrated all projects to packagereference #739

merged 1 commit into from
Aug 10, 2019

Conversation

Barsonax
Copy link
Member

@Barsonax Barsonax commented Aug 4, 2019

Solves #736

After this the nuget and netstandard branch need to get updated again (should make the changes in those branches alot smaller though).

@ilexp ilexp added DevTool Area: Development tools and environment Task ToDo that's neither a Bug, nor a Feature labels Aug 4, 2019
@ilexp ilexp added this to the C# / .NET Upgrade milestone Aug 4, 2019
@ilexp
Copy link
Member

ilexp commented Aug 4, 2019

Nice 👍 Will review and merge soon-ish.

Note to self, things to check:

  • Does it compile fine "on my machine" in addition to yours + AppVeyor after fresh checkout?
  • Do a brief editor install check via local package repo, just in case.

@Barsonax
Copy link
Member Author

Barsonax commented Aug 5, 2019

Took the liberty of rebasing the netstandard branch and nuget branch in advance on this branch to solve any merge conflicts.

These branches need to be rebased again once this PR is merged to master (should be easy since all conflicts are fixed already).

See #740 and #741 for comparison/discussion.

@ilexp
Copy link
Member

ilexp commented Aug 10, 2019

Took a clean / rebuild on my previous checkout to get rid of some dependency errors, in case anyone runs into this as well - compiles just fine from scratch though. Also did a quick package build and test install in a local repo and it looks like nothing changed on the binary output / compatibility side, as expected.

Merging this.

@ilexp ilexp merged commit 0f9d0fa into AdamsLair:master Aug 10, 2019
@Barsonax Barsonax deleted the feature/packagereferenupdate branch August 10, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevTool Area: Development tools and environment Task ToDo that's neither a Bug, nor a Feature
Development

Successfully merging this pull request may close these issues.

2 participants