Change plugin projects to netstandard and sdk style csproj's #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barsonax
changed the title
Barsonax
commented
Aug 5, 2019
Barsonax
changed the title
Barsonax
commented
Aug 5, 2019
|
Rebased on latest master, changes are down from 59 to 32 files :) |
cowmanjoe
reviewed
Oct 21, 2019
Comment on lines
8
to
10
| <PropertyGroup> | ||
| <DualityPackageExcludeParentElement /> | ||
| <StartAction>Program</StartAction> | ||
| <StartProgram>$(SolutionDir)Build\Output\DualityEditor.exe</StartProgram> | ||
| <StartWorkingDirectory>..\</StartWorkingDirectory> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Indentation seems inconsistent in this file, similarly in other csproj files
| @@ -230,6 +231,7 @@ public static string CreateNewProject(string projName, string projFolder, Projec | |||
| compileElement.AddAfterSelf(newCompileElement); | |||
| } | |||
| coreProject.Save(SourceCodeProjectCorePluginFile); | |||
| */ | |||
There was a problem hiding this comment.
Why not just remove this entirely instead of commenting it out?
ilexp
added
DevTool
Barsonax
referenced
this pull request
Apr 21, 2020
…ckage management (#789) #CHANGE: Removed package manager and new project logic in favor of csproj based package management, bumped version to 4.0.0-alpha
This was
linked to
issues
Apr 21, 2020
SirePi
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Also solves #743