Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sceneViewsettings #870

Merged
merged 4 commits into from
Aug 7, 2020
Merged

update sceneViewsettings #870

merged 4 commits into from
Aug 7, 2020

Conversation

Barsonax
Copy link
Member

No description provided.

@ilexp ilexp mentioned this pull request Jul 14, 2020
Merged
@ilexp ilexp linked an issue Jul 14, 2020 that may be closed by this pull request
Refactor/rethink how duality handles settings #855
Open
@ilexp ilexp added this to the 4.0 milestone Jul 14, 2020
@ilexp ilexp added Editor Area: Duality editor or support libraries Plugin Area: Misc. core / editor plugins Task ToDo that's neither a Bug, nor a Feature labels Jul 14, 2020
@ilexp ilexp mentioned this pull request Jul 22, 2020
Open
@Barsonax Barsonax requested review from ilexp and SirePi July 27, 2020 18:51
@Barsonax
Copy link
Member Author

Ready for a review @ilexp @SirePi

ilexp
ilexp requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@ilexp ilexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add aside from the usual "XML docs!!" request and a few tiny style things 👍

Source/Plugins/EditorModules/SceneView/SceneViewSettings.cs Show resolved Hide resolved
Source/Plugins/EditorModules/SceneView/Modules/SceneView.cs Show resolved Hide resolved
Source/Plugins/EditorModules/SceneView/Modules/SceneView.cs Show resolved Hide resolved
Source/Plugins/EditorModules/SceneView/Modules/SceneView.cs Show resolved Hide resolved
@Barsonax Barsonax requested a review from ilexp August 5, 2020 18:26
@Barsonax Barsonax merged commit c85ed95 into AdamsLair:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilexp ilexp ilexp approved these changes

@SirePi SirePi Awaiting requested review from SirePi

Assignees
No one assigned
Labels
Editor Area: Duality editor or support libraries Plugin Area: Misc. core / editor plugins Task ToDo that's neither a Bug, nor a Feature
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Refactor/rethink how duality handles settings
2 participants
@Barsonax @ilexp