Prevent division by zero when tab bar width is 0 #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
Basically, in
DockArea::tab_bar_scroll
, the scrolling coefficient is determined by a calculation which involves division by the available width. The problem is that when the available width is 0, the division results in infinity which is later multiplied by 0, and that produces a NaN here:The
scroll
coefficient is later used all over the tab bar code, which spreads the NaN like a disease.My fix for this is basically just turning off all tab bar code when the width is 0.
I also did a bit of clean-up: the
Response
returned fromDockArea::tab_bar
is only ever used to obtain the occupiedRect
, so I made the function just return theRect
instead.