Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas intersphinx mapping; fix test setup #136

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Conversation

stes
Copy link
Member

@stes stes commented Mar 27, 2024

In #135 , the tests show a few errors that are due to upstream changes in our dependencies. This PR fixes the build errors:

  • Update the URL of the pandas intersphinx mapping to the current stable version (vs. the dev version, which we used previously). This fixes the issue during docs build due to a missing reference.
  • Pin pytest and pytest-sphinx to a previous release --- we use pytest-sphinx, which is not yet compatible with the latest pytest version.

@cla-bot cla-bot bot added the CLA signed label Mar 27, 2024
@stes
Copy link
Member Author

stes commented Mar 27, 2024

Confirmed, can repro error from #135 :
image

@stes
Copy link
Member Author

stes commented Mar 27, 2024

Upstream issue seems to be this line (https://github.com/thisch/pytest-sphinx/blob/2d995d2a4bb59d6e09610115740a9da2bc3d0c36/src/pytest_sphinx.py#L560), potentially due to API change in Pytest (https://pypi.org/project/pytest/#history) version 8.

@stes stes self-assigned this Mar 27, 2024
@stes
Copy link
Member Author

stes commented Mar 28, 2024

updated the intersphinx path to pandas, the prev version already contained the dev preview:
image

likely this caused the error

@stes stes requested a review from MMathisLab March 28, 2024 14:46
@stes stes changed the title Update test setup Fix pandas intersphinx mapping; fix test setup Mar 28, 2024
Copy link
Member

@MMathisLab MMathisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks

@MMathisLab MMathisLab merged commit bbf9f6e into main Apr 11, 2024
14 checks passed
@stes stes deleted the stes/rerun-tests branch February 19, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants