Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend type checking to all float datatypes #166

Merged
merged 10 commits into from
Oct 26, 2024
Merged

Extend type checking to all float datatypes #166

merged 10 commits into from
Oct 26, 2024

Conversation

CeliaBenquet
Copy link
Member

@CeliaBenquet CeliaBenquet commented Aug 23, 2024 •
edited by MMathisLab
Loading

This allows for someone to use discrete labels in a continuous way; this might change the solver to behaviors you might not be expecting so please use with caution.

fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/791
fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/790

@cla-bot cla-bot bot added the CLA signed label Aug 23, 2024
@CeliaBenquet CeliaBenquet requested a review from stes August 23, 2024 11:41
@CeliaBenquet CeliaBenquet self-assigned this Aug 23, 2024
@MMathisLab MMathisLab added the enhancement New feature or request label Aug 23, 2024
@MMathisLab MMathisLab force-pushed the celia/fix-790-public branch from 0d169cb to 2d5b0b5 Compare August 23, 2024 22:53
stes
stes requested changes Aug 24, 2024
View reviewed changes
cebra/data/datasets.py Show resolved Hide resolved
cebra/data/datasets.py Outdated Show resolved Hide resolved
@MMathisLab MMathisLab requested a review from stes September 25, 2024 16:11
@CeliaBenquet
Copy link
Member Author

CeliaBenquet commented Sep 27, 2024 •
edited
Loading

docs building git action doesn't pass is fixed in #176

@stes stes mentioned this pull request Oct 20, 2024
Closed
@stes
Copy link
Member

stes commented Oct 20, 2024

docs should build again now, main tests not yet. Working on that now.

@stes stes mentioned this pull request Oct 20, 2024
Merged
@stes
Copy link
Member

stes commented Oct 20, 2024

All right, after #184 this should hopefully finally build!

@stes
Copy link
Member

stes commented Oct 20, 2024 •
edited
Loading

Ok, raises an actual error:
image

@CeliaBenquet wanna have a shot at fixing this? otherwise I can have a look.

stes
stes reviewed Oct 26, 2024
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix type checking and error message

cebra/data/datasets.py Outdated Show resolved Hide resolved
cebra/data/datasets.py Outdated Show resolved Hide resolved
@stes
Copy link
Member

stes commented Oct 26, 2024

Let's see if this fixes the error

stes
stes approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

icarosadero
icarosadero approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@icarosadero icarosadero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stes I think this does the trick 👍

@stes stes merged commit 0e2312a into AdaptiveMotorControlLab:main Oct 26, 2024
11 checks passed
@stes stes mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icarosadero icarosadero icarosadero approved these changes

@stes stes stes approved these changes

Assignees

@CeliaBenquet CeliaBenquet

Labels
CLA signed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CeliaBenquet @stes @icarosadero @MMathisLab