Remove subsample
default in OrthogonalProcrustesAlignment
, improve tests
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple tests failed internally and on this repo (e.g., in #20 , #25, #26) due to a numerical issue in
OrthogonalProcrustesAlignment
when a too small value forsubsample
is used.This PR fixes this by setting the default to
None
, which means that all points available in the embedding are used for alignment. This is the numerically best option. In other cases, warnings are emitted, when e.g. the values ofsubsample
is smaller than the number of points in the dataset, or when the number ofsubsample
is smaller than 1000 (a reasonable default).This PR also improves the tests, and removes the
atol
value of several tests, or at least decreases it slightly to avoid false negatives in the future.Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/647
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/645
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/644