Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtypes handled in the labels of the decoders #30

Merged

Conversation

CeliaBenquet
Copy link
Member

int and float subtypes accepted to be in the labels of the decoders were hard coded, which results in errors for int8 for instance.

Now, it supports all subtypes of Integer and floating in numpy arrays and pytorch tensors.

  • adapted the corresponding tests.

Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/616

@CeliaBenquet CeliaBenquet added the bug Something isn't working label Jun 29, 2023
@CeliaBenquet CeliaBenquet requested a review from stes June 29, 2023 16:04
@CeliaBenquet CeliaBenquet self-assigned this Jun 29, 2023
@cla-bot cla-bot bot added the CLA signed label Jun 29, 2023
@stes stes force-pushed the celia/dtype-decoder branch from 06199ad to cf77d2e Compare June 29, 2023 19:29
@stes
Copy link
Member

stes commented Jun 29, 2023

Seems like the documentation status still fails due to

image

I'll disable the comment function for now so we can merge this and other upcoming PRs, the check is still executed.

tests/test_sklearn_decoder.py Show resolved Hide resolved
@stes stes force-pushed the celia/dtype-decoder branch from f35f6e7 to b2b07bd Compare July 5, 2023 23:24
@stes stes requested a review from MMathisLab July 5, 2023 23:24
@MMathisLab MMathisLab merged commit 6984b53 into AdaptiveMotorControlLab:main Jul 6, 2023
@stes stes deleted the celia/dtype-decoder branch July 6, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants