Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For docs build, limit scikit-learn version #37

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

stes
Copy link
Member

@stes stes commented Jun 30, 2023

It seems like scikit-learn updated to 1.3.0 a few hours ago (https://pypi.org/project/scikit-learn/#history), but their index for doc build is not updated. This causes and issue that we tracked in https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/649.

I propose to temporarily pin sklearn below 1.3.0 only for docs build, which wont affect the main package, to fix this issue. Then, once the object files are updated and published by sklearn, we can unpin again. I will set a reminder to do that within a few weeks.

This will otherwise block merging a few PRs in the upcoming days.


Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/649

@cla-bot cla-bot bot added the CLA signed label Jun 30, 2023
@github-actions
Copy link
Contributor

Docstring Coverage Report

Name Total Miss Cover Cover%
main.py 5 1 4 80%
config.py 6 4 2 33%
data/datatypes.py 5 2 3 60%
data/helper.py 6 1 5 83%
data/multi_session.py 12 5 7 58%
datasets/demo.py 8 3 5 62%
datasets/gaussian_mixture.py 3 2 1 33%
datasets/hippocampus.py 7 1 6 86%
datasets/save_dataset.py 4 1 3 75%
datasets/allen/single_session_ca.py 9 3 6 67%
distributions/discrete.py 9 2 7 78%
distributions/multisession.py 5 1 4 80%
integrations/sklearn/helpers.py 2 1 1 50%
integrations/sklearn/metrics.py 3 1 2 67%
integrations/sklearn/utils.py 6 1 5 83%
models/projector.py 12 9 3 25%
------------------------------------------ -------- ------- -------- ---------
TOTAL 396 38 358 90.4%
(45 of 61 files omitted due to complete coverage)

RESULT: PASSED (minimum: 90.0%, actual: 90.4%)

@stes stes requested a review from MMathisLab June 30, 2023 15:13
@stes stes self-assigned this Jun 30, 2023
@stes stes added bug Something isn't working documentation Improvements or additions to documentation labels Jun 30, 2023
@MMathisLab MMathisLab merged commit 73acd43 into main Jun 30, 2023
@stes stes deleted the stes/pin-sklearn-version branch June 30, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants