Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config to standardize files #42

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Add pre-commit config to standardize files #42

merged 13 commits into from
Jul 12, 2023

Conversation

stes
Copy link
Member

@stes stes commented Jul 12, 2023

This PR moves from using manual formatting to formatting defined with pre-commit. The make format routine was also adapted accordingly.

Note, the formatting was intentially not run on all third_party files, to make it easier to compare these to original versions.

Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/646

@cla-bot
Copy link

cla-bot bot commented Jul 12, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CEBRA.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@stes stes requested a review from MMathisLab July 12, 2023 02:46
@stes stes force-pushed the stes/pre-commit branch from fe63c87 to b3fdce4 Compare July 12, 2023 02:47
@cla-bot
Copy link

cla-bot bot commented Jul 12, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CEBRA.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@MMathisLab
Copy link
Member

@cla-bot
Copy link

cla-bot bot commented Jul 12, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CEBRA.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@stes stes merged commit f3c4f0a into main Jul 12, 2023
@stes stes deleted the stes/pre-commit branch July 12, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants