Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support More Data Types in the sklearn Dataset and Decoder #43

Merged
merged 22 commits into from
Jul 15, 2023
Merged

Support More Data Types in the sklearn Dataset and Decoder #43

merged 22 commits into from
Jul 15, 2023

Conversation

gonlairo
Copy link
Contributor

@gonlairo gonlairo commented Jul 12, 2023 •
edited
Loading

Fix #39.

Moved helper functions is_integer() and is_floating() into cebra.helper and used them to support more data types both in the sklearn dataset and in the sklearn decoder. The get_loader_options() functions is moved into cebra.data.helpers.

@cla-bot cla-bot bot added the CLA signed label Jul 12, 2023
@stes stes force-pushed the rodrigo/fix-dtypes branch from 5534371 to b9770ce Compare July 12, 2023 11:36
@stes stes self-requested a review July 12, 2023 11:36
@gonlairo gonlairo changed the title support more data types in the sklearn dataset and decoder Support More Data Types in the sklearn Dataset and Decoder Jul 12, 2023
@stes stes force-pushed the rodrigo/fix-dtypes branch from b9770ce to ae3fddc Compare July 13, 2023 16:01
@stes
Copy link
Member

stes commented Jul 13, 2023

note, prev failure on doc build was an upstream issue. lets see if rerunning fixes it. error message from action

intersphinx inventory 'https://matplotlib.org/stable/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 522 Server Error:  for url: https://matplotlib.org/stable/objects.inv

stes
stes approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stes stes requested review from MMathisLab and CeliaBenquet July 13, 2023 18:11
CeliaBenquet
CeliaBenquet approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@CeliaBenquet CeliaBenquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@MMathisLab MMathisLab merged commit c95bd5a into AdaptiveMotorControlLab:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stes stes stes approved these changes

@MMathisLab MMathisLab MMathisLab approved these changes

@CeliaBenquet CeliaBenquet CeliaBenquet approved these changes

Assignees

@gonlairo gonlairo

Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sklearn-API: support of all the integer types as discrete labels?
4 participants
@gonlairo @stes @MMathisLab @CeliaBenquet