Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodownload monkey reaching data #59

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Autodownload monkey reaching data #59

merged 6 commits into from
Sep 9, 2023

Conversation

gonlairo
Copy link
Contributor

@gonlairo gonlairo commented Sep 5, 2023 •
edited
Loading

  • Data is downloaded automatically vs. manual download from figshare. Ex. on the primate reaching dataset.

Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/664

@cla-bot cla-bot bot added the CLA signed label Sep 5, 2023
@gonlairo gonlairo self-assigned this Sep 5, 2023
@stes stes force-pushed the rodrigo/autodownload-monkey-reaching-data branch from 34ebee5 to a4f1c5e Compare September 5, 2023 11:48
@stes stes self-requested a review September 5, 2023 11:49
stes
stes reviewed Sep 9, 2023
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining issue is the way we download some external data for testing. I will fix this in another PR, then we should be able to merge this one.

@stes stes mentioned this pull request Sep 9, 2023
Merged
stes
stes approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now!

@stes stes merged commit 977ca7f into AdaptiveMotorControlLab:main Sep 9, 2023
@stes stes deleted the rodrigo/autodownload-monkey-reaching-data branch September 9, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stes stes stes approved these changes

@MMathisLab MMathisLab MMathisLab approved these changes

Assignees

@gonlairo gonlairo

Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gonlairo @stes @MMathisLab