Improve saving and loading of models #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stes
requested changes
Sep 13, 2023
Co-authored-by: Steffen Schneider <steffen@bethgelab.org>
Co-authored-by: Steffen Schneider <steffen@bethgelab.org>
Co-authored-by: Steffen Schneider <steffen@bethgelab.org>
Co-authored-by: Steffen Schneider <steffen@bethgelab.org>
MMathisLab
requested changes
Sep 13, 2023
This was referenced Sep 14, 2023
Merged
stes
approved these changes
Oct 1, 2023
- refine message on fxn
MMathisLab
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve model saving in the sklearn API to ensure future compatibility and safety. Currently, we save the entire object using torch.save, which may cause issues with different CEBRA versions. This pull request (PR) tackles this problem by suggesting a solution that involves saving only the model weights and all the arguments used, allowing for complete reconstruction of the CEBRA object at loading time.
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/643
Fix #33
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/623