Equity grant test by Adarsh9977 · Pull Request #1 · Adarsh9977/flexile

Adarsh9977 · 2025-08-02T15:25:21Z

Summary by cubic

Removed legacy onboarding logic and pages, updated onboarding to use a checklist for investors and workers, and added a new modal-based equity grant flow.

New Features
- Added onboarding checklist support for investors and combined roles.
- Introduced a modal for issuing equity grants.
Refactors
- Removed backend onboarding controllers, services, policies, and related tests.
- Cleaned up routes and frontend onboarding components.
- Updated checklist logic and sidebar display to use new onboarding approach.

…equity-grant

cubic-dev-ai

cubic analysis

7 issues found across 76 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

cubic-dev-ai · 2025-08-02T15:33:19Z

frontend/app/settings/page.tsx

+          error_message: z.string().optional(),
+          error: z.string().optional(),
+        });
+        const errorData = errorSchema.parse(await response.json().catch(() => ({})));


Using errorSchema.parse here will throw a ZodError if the response shape deviates (for example if types differ), which then surfaces an unfriendly technical message to the user. Consider safeParse and falling back to a default error string instead. (Based on your team's feedback about providing user-friendly error handling.)

Prompt for AI agents

Address the following comment on frontend/app/settings/page.tsx at line 130: <comment>Using errorSchema.parse here will throw a ZodError if the response shape deviates (for example if types differ), which then surfaces an unfriendly technical message to the user. Consider safeParse and falling back to a default error string instead. (Based on your team's feedback about providing user-friendly error handling.)</comment> <file context> @@ -123,11 +123,16 @@ const LeaveWorkspaceSection = () => { }); if (!response.ok) { - const errorData = await response.json().catch(() => null); - throw new Error(errorData?.error_message || errorData?.error || "Failed to leave workspace"); + const errorSchema = z.object({ + error_message: z.string().optional(), + error: z.string().optional(), + }); </file context>

cubic-dev-ai · 2025-08-02T15:33:20Z

frontend/app/settings/tax/page.tsx

      zip_code: data.zip_code ?? "",
      street_address: data.street_address ?? "",
      birth_date: data.birth_date ? parseDate(data.birth_date) : null,
+      citizenship_country_code: data.citizenship_country_code ?? "",


Defaulting citizenship_country_code to an empty string treats the user as a foreign taxpayer and changes validation / UI flows even when their citizenship is actually unknown.

Prompt for AI agents

Address the following comment on frontend/app/settings/tax/page.tsx at line 117: <comment>Defaulting citizenship_country_code to an empty string treats the user as a foreign taxpayer and changes validation / UI flows even when their citizenship is actually unknown.</comment> <file context> @@ -114,6 +114,9 @@ export default function TaxPage() { zip_code: data.zip_code ?? "", street_address: data.street_address ?? "", birth_date: data.birth_date ? parseDate(data.birth_date) : null, + citizenship_country_code: data.citizenship_country_code ?? "", + legal_name: data.legal_name ?? "", + country_code: data.country_code ?? "", </file context>

Suggested change

citizenship_country_code: data.citizenship_country_code ?? "",

citizenship_country_code: data.citizenship_country_code ?? "US",

cubic-dev-ai · 2025-08-02T15:33:20Z

frontend/app/(dashboard)/equity/grants/NewEquityGrantModal.tsx

+                      <ComboBox
+                        {...field}
+                        options={data.workers
+                          .sort((a, b) => a.user.name.localeCompare(b.user.name))


Sorting mutates the data.workers array in place, potentially corrupting the TRPC cache and causing side-effects elsewhere. Use a copied array before sort to keep fetched data immutable. (Based on your team's feedback about avoiding in-place mutation of shared data.)

Prompt for AI agents

Address the following comment on frontend/app/(dashboard)/equity/grants/NewEquityGrantModal.tsx at line 233: <comment>Sorting mutates the data.workers array in place, potentially corrupting the TRPC cache and causing side-effects elsewhere. Use a copied array before sort to keep fetched data immutable. (Based on your team's feedback about avoiding in-place mutation of shared data.)</comment> <file context> @@ -0,0 +1,606 @@ +"use client"; + +import { zodResolver } from "@hookform/resolvers/zod"; +import { CalendarDate, getLocalTimeZone, today } from "@internationalized/date"; +import { ChevronDown, ChevronRight } from "lucide-react"; +import { useEffect, useState } from "react"; +import { useForm } from "react-hook-form"; +import { z } from "zod"; +import TemplateSelector from "@/app/(dashboard)/document_templates/TemplateSelector"; </file context>

Suggested change

.sort((a, b) => a.user.name.localeCompare(b.user.name))

.slice().sort((a, b) => a.user.name.localeCompare(b.user.name))

cubic-dev-ai · 2025-08-02T15:33:20Z

frontend/app/(dashboard)/equity/grants/NewEquityGrantModal.tsx

+          }),
+      });
+
+      const errorInfo = errorInfoSchema.parse(JSON.parse(error.message));


Assumes error.message is always valid JSON; if it is not, JSON.parse will throw and mask the original error, breaking the error handler. Wrap parsing in try/catch or safely parse.

Prompt for AI agents

Address the following comment on frontend/app/(dashboard)/equity/grants/NewEquityGrantModal.tsx at line 159: <comment>Assumes error.message is always valid JSON; if it is not, JSON.parse will throw and mask the original error, breaking the error handler. Wrap parsing in try/catch or safely parse.</comment> <file context> @@ -0,0 +1,606 @@ +"use client"; + +import { zodResolver } from "@hookform/resolvers/zod"; +import { CalendarDate, getLocalTimeZone, today } from "@internationalized/date"; +import { ChevronDown, ChevronRight } from "lucide-react"; +import { useEffect, useState } from "react"; +import { useForm } from "react-hook-form"; +import { z } from "zod"; +import TemplateSelector from "@/app/(dashboard)/document_templates/TemplateSelector"; </file context>

cubic-dev-ai · 2025-08-02T15:33:20Z

frontend/app/(dashboard)/equity/grants/NewEquityGrantModal.tsx

+      ? (Number(data.sharePriceUsd) * numberOfShares).toFixed(2)
+      : null;
+
+  const isFormValid = form.formState.isValid;


isValid only updates after a validation trigger; without specifying mode:"onChange" or manually calling trigger, the button will remain disabled until the user submits once, leading to confusing UX.

Prompt for AI agents

Address the following comment on frontend/app/(dashboard)/equity/grants/NewEquityGrantModal.tsx at line 110: <comment>isValid only updates after a validation trigger; without specifying mode:"onChange" or manually calling trigger, the button will remain disabled until the user submits once, leading to confusing UX.</comment> <file context> @@ -0,0 +1,606 @@ +"use client"; + +import { zodResolver } from "@hookform/resolvers/zod"; +import { CalendarDate, getLocalTimeZone, today } from "@internationalized/date"; +import { ChevronDown, ChevronRight } from "lucide-react"; +import { useEffect, useState } from "react"; +import { useForm } from "react-hook-form"; +import { z } from "zod"; +import TemplateSelector from "@/app/(dashboard)/document_templates/TemplateSelector"; </file context>

cubic-dev-ai · 2025-08-02T15:33:20Z

frontend/app/(dashboard)/equity/grants/page.tsx

        </DialogContent>
      </Dialog>
+
+      <NewEquityGrantModal open={showNewGrantModal} onOpenChange={setShowNewGrantModal} />


NewEquityGrantModal is rendered unconditionally, so its heavy data-fetching hooks run even when the modal is closed, causing an unnecessary network request and wasted work (Based on your team's feedback about avoiding unnecessary queries on initial render).

Prompt for AI agents

Address the following comment on frontend/app/(dashboard)/equity/grants/page.tsx at line 169: <comment>NewEquityGrantModal is rendered unconditionally, so its heavy data-fetching hooks run even when the modal is closed, causing an unnecessary network request and wasted work (Based on your team's feedback about avoiding unnecessary queries on initial render).</comment> <file context> @@ -182,6 +165,8 @@ export default function GrantsPage() { ) : null} </DialogContent> </Dialog> + + <NewEquityGrantModal open={showNewGrantModal} onOpenChange={setShowNewGrantModal} /> </> ); </file context>

Suggested change

<NewEquityGrantModal open={showNewGrantModal} onOpenChange={setShowNewGrantModal} />

{showNewGrantModal && (

<NewEquityGrantModal open={showNewGrantModal} onOpenChange={setShowNewGrantModal} />

)}

cubic-dev-ai · 2025-08-02T15:33:20Z

frontend/app/(dashboard)/invoices/page.tsx

+        {user.roles.worker ? (
+          !hasLegalDetails ? (
+            <Alert>
+              <Info />


Icon size is missing; omit of "className="size-5"" makes this Lucide icon larger than the rest of the alert icons, breaking visual consistency.

Prompt for AI agents

Address the following comment on frontend/app/(dashboard)/invoices/page.tsx at line 326: <comment>Icon size is missing; omit of "className=\"size-5\"" makes this Lucide icon larger than the rest of the alert icons, breaking visual consistency.</comment> <file context> @@ -347,11 +320,45 @@ export default function InvoicesPage() { /> <div className="grid gap-4"> - {workerNotice ? ( - <Alert> - <Info className="size-5" /> - <AlertDescription>{workerNotice}</AlertDescription> - </Alert> + {user.roles.worker ? ( </file context>

Suggested change

<Info />

<Info className="size-5" />

Adarsh9977 and others added 10 commits July 31, 2025 01:17

added new flow

989cfbb

disable button

d5bf913

removed prev logic and added button

a1a0b33

fix

3f4c6c2

added test

1a4258e

Merge branch 'main' into equity-grant

328d91b

fix

215728f

Merge remote-tracking branch 'refs/remotes/origin/equity-grant' into …

0f0ceb1

…equity-grant

Merge branch 'main' into equity-grant

ec9ec78

test

31f5e35

cubic-dev-ai bot reviewed Aug 2, 2025

View reviewed changes

Adarsh9977 and others added 11 commits August 2, 2025 21:27

fix

dd2331d

test-fix

0290d48

5f11bc1

Merge branch 'main' into equity-grant

89aabce

fix re-renders

ffd2912

fix

0587dce

fix validation

acb9f58

Merge branch 'main' into equity-grant

26acaf2

added form logic to enable button

c780fbf

Merge branch 'main' into equity-grant

cae12a7

Merge branch 'equity-grant' into equity-grant-test

92e8e11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Equity grant test#1

Equity grant test#1
Adarsh9977 wants to merge 21 commits intomainfrom
equity-grant-test

Adarsh9977 commented Aug 2, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

	citizenship_country_code: data.citizenship_country_code ?? "",
	citizenship_country_code: data.citizenship_country_code ?? "US",

	.sort((a, b) => a.user.name.localeCompare(b.user.name))
	.slice().sort((a, b) => a.user.name.localeCompare(b.user.name))

Conversation

Adarsh9977 commented Aug 2, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Adarsh9977 commented Aug 2, 2025 •

edited by cubic-dev-ai bot

Loading